Do not use self type in Validate #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #715 +/- ##
=======================================
Coverage 94.22% 94.22%
=======================================
Files 62 62
Lines 762 762
Branches 7 7
=======================================
Hits 718 718
Misses 44 44
Continue to review full report at Codecov.
|
SethTisue
pushed a commit
to SethTisue/refined
that referenced
this pull request
Jan 22, 2020
* Do not wrap c.eval in Try * Do not remove tryN because of bincompat * Remove self type * tryN is still needed
SethTisue
pushed a commit
to scalacommunitybuild/refined
that referenced
this pull request
Jan 22, 2020
* Do not wrap c.eval in Try * Do not remove tryN because of bincompat * Remove self type * tryN is still needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change might prevent the compiler crash reported in #260 by removing the self type in
Validate(see #260 (comment)). Since I haven't been able to reproduce or even observe the crash in #260, I can't say if this actually improves anything.