Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support monorepos with scala subfolders #678

Closed
pvillega opened this issue Jul 9, 2019 · 9 comments · Fixed by #1875
Closed

Support monorepos with scala subfolders #678

pvillega opened this issue Jul 9, 2019 · 9 comments · Fixed by #1875
Labels
enhancement New feature or request

Comments

@pvillega
Copy link

pvillega commented Jul 9, 2019

We currently have a project in which the scala project is located in a subfolder in the repo. Currently Steward can't identify that project as a Scala project, and it ignores it.

We would need a way to indicate a subfolder in a git repository where the scala project is located.

We are aware that there is a closed issue regarding projects following the Play/Akka structure, but this is a different issue.

@exoego
Copy link
Contributor

exoego commented Jul 9, 2019

Similar to #46

@pvillega
Copy link
Author

pvillega commented Jul 9, 2019

Yes, but not exactly the same as #46 if I understand correctly. #46 seems to be focussed on Play projects (based on examples), this is more 'any subfolder that can be a full project by itself'. Then again I may be misreading :)

@exoego
Copy link
Contributor

exoego commented Jul 9, 2019

Yes, I mean this issue seems to supersede #46, since #46 can be achieved if 'any subfolder` can be a full project.

@exoego
Copy link
Contributor

exoego commented Jul 10, 2019

I am working on this.

@ashawley
Copy link

Will this also make it possible to support repos that contain Giter8 templates?

Here's an example: https://github.com/scala/scala-seed.g8

@ashawley
Copy link

Will this also make it possible to support repos that contain Giter8 templates?

I saw that Scala Steward is at least updating the sbt version of a g8 tempmlate, see scala/scalatest-example.g8#14

@kluen
Copy link

kluen commented Jul 31, 2020

Hi @exoego, just curious, is this still being worked on?

@exoego
Copy link
Contributor

exoego commented Jul 31, 2020

No, I am no longer working on this feature (I closed my WIP PR #721).
Anyone can take over the PR.

FYI, #1093 is another approach for this feature.

@kluen
Copy link

kluen commented Jul 31, 2020

Thanks for the info, I haven't found those PRs :)

@fthomas fthomas linked a pull request Jan 15, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants