Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "release-$version" as possible tag for diffs and release notes #1083

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@fthomas
Copy link
Owner

fthomas commented Nov 7, 2019

When looking for version diffs and release notes we now also check URLs
that contain tags like release-$version.

ScalaTest uses this scheme for their tags. Here is an example PR that
now includes links to the version diff and release notes because of this
change: fthomas/refined-sjs-example#67

When looking for version diffs and release notes we now also check URLs
that contain tags like `release-$version`.

ScalaTest uses this scheme for their tags. Here is an example PR that
now includes links to the version diff and release notes because of this
change: fthomas/refined-sjs-example#67
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #1083 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1083      +/-   ##
==========================================
+ Coverage   67.99%   68.05%   +0.06%     
==========================================
  Files          90       90              
  Lines        1459     1462       +3     
  Branches       34       36       +2     
==========================================
+ Hits          992      995       +3     
  Misses        467      467
Impacted Files Coverage Δ
...main/scala/org/scalasteward/core/vcs/package.scala 100% <100%> (ø) ⬆️
...a/org/scalasteward/core/coursier/CoursierAlg.scala 96.66% <0%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 030f2a9...4156f4c. Read the comment docs.

@fthomas fthomas added this to the 0.5.0 milestone Nov 7, 2019
@fthomas fthomas added the enhancement label Nov 7, 2019
@fthomas fthomas merged commit 05ab0a7 into master Nov 7, 2019
6 checks passed
6 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Summary no rules match, no planned actions
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 67.99%)
Details
codecov/project 68.05% (+0.06%) compared to 030f2a9
Details
@fthomas fthomas deleted the topic/release-tag branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.