Add update state UpdateRejectedByConfig #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pruning repos, Scala Steward now takes into account if updates are rejected by repo configuration. This will prevent Scala Steward from unnecessarily working on repos where it determined that a dependency is outdated but it was actually ignored by the repo config.
Codecov Report
@@ Coverage Diff @@
## master #836 +/- ##
=========================================
- Coverage 66.31% 66.2% -0.11%
=========================================
Files 88 88
Lines 1235 1237 +2
Branches 37 39 +2
=========================================
Hits 819 819
- Misses 416 418 +2
Continue to review full report at Codecov.
|
exoego
reviewed
Aug 15, 2019
| PullRequestUpToDate(dependency, update, uri) | ||
| case Some((uri, _, _)) => | ||
| PullRequestOutdated(dependency, update, uri) | ||
| repoCache.maybeRepoConfig.map(_.updates.keep(update)) match { |
There was a problem hiding this comment.
Can Steward update a dependency again if the dependency is removed from ignore list in repo config?
There was a problem hiding this comment.
Yes. If the repo config does not ignore it any longer _.updates.keep will return a Right(_) there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pruning repos, Scala Steward now takes into account if updates are
rejected by repo configuration. This will prevent Scala Steward from
unnecessarily working on repos where it determined that a dependency is
outdated but it was actually ignored by the repo config.