This repository has been archived by the owner on Jun 9, 2022. It is now read-only.
Search #7
Merged
Search #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This all looks good to me 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adaroseedwards, @JakeChampion, @railsagainstignorance
Got search working again. I've updated the code to use Next's newer Elasticsearch index. We can again do:
search <topic>A<id>Metadata needs more work, I've left that mostly untouched.
Mostly an experimental branch to hook the chatbot up with the new search stuff. Still needs work, and I've left most of the old code intact (renamed to
byText_old). I had to usesigned-aws-es-fetchinstead ofrequestbuilder, so there may be a bit more to do to get those two working together.I've requested AWS keys for Labs (needed in ENV to be able to use next-elastic.ft.com). Should get them shortly. I'll add them to LastPass.