Skip to content
This repository has been archived by the owner on Jun 9, 2022. It is now read-only.

Added support for mouseup and mousedown event support #289

Closed
wants to merge 3 commits into from

Conversation

lihan
Copy link

@lihan lihan commented Aug 22, 2014

Added support for mouseup and mousedown event support.
This fixed that some dropdown plugin relies on mouseup and mousedown event, and it doesn't work in fastclick.

@matthew-andrews
Copy link
Contributor

Shoudn't that be the other way around? So like this:

  • mousedown
  • mouseup
  • click

Instead of:

  • mouseup
  • mousedown
  • click

[See here: http://jsbin.com/qanitu/1/edit?js,console,output]

Also there seems to be a slight whitespace issue.

(I've created a pull request into your pull request to fix these things - lihan#1)

…pport

Switch order of mouse up/mouse down, fix slight whitespace issue
@vogdb
Copy link
Contributor

vogdb commented Sep 22, 2014

@matthew-andrews @lihan Please look at the update. Please lets not have the same long-running story here as we had with #103.

@matthew-andrews
Copy link
Contributor

Thanks for the reminder @vogdb. @lihan I've created a PR into your PR that merges the changes from master so that this PR might be mergeable would you be able to review:-
https://github.com/lihan/fastclick/pull/2/files?w=false

@vogdb
Copy link
Contributor

vogdb commented Oct 8, 2014

@lihan started this PR to make changes faster than #103 but instead we have another long-running PR 😆
@matthew-andrews I'm afraid of asking. How can we make these changes go alive? Should I start another PR to finish this fuss?

@matthew-andrews
Copy link
Contributor

@vogdb I've created a new one that's mergeable - #308

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants