Skip to content
This repository has been archived by the owner on Jun 9, 2022. It is now read-only.

Use mount event so it survives parent rerenders #8

Merged
merged 2 commits into from Sep 14, 2015

Conversation

apaleslimghost
Copy link
Contributor

@apaleslimghost
Copy link
Contributor Author

lol, whoops

@apaleslimghost
Copy link
Contributor Author

The current tests actually work fine with fruitmachine master. Can someone with npm permissions release 1.1?

kornelski added a commit that referenced this pull request Sep 14, 2015
Use mount event so it survives parent rerenders
@kornelski kornelski merged commit fa0ff6c into ftlabs:master Sep 14, 2015
@kornelski
Copy link
Contributor

No it doesn't:

Failure: PhantomJS 1.9.8, Linux | fruitmachine-ftdomdelegate | on mount a dom-delegate should have its root method called once with the module's el and nothing more
[assert] Expected false to be truthy
at ./test/tests/helper.test.js:54
Running 4 tests in 1 runtime ... 75% done
4 tests, 13 assertions, 1 runtime ... 1 failure
Warning: Task "buster:test" failed.� Use --force to continue.

@apaleslimghost
Copy link
Contributor Author

The tests use the built version of fruitmachine, which wasn't updated on publish of 1.1.0. I've created ftlabs/fruitmachine#90 to make sure it gets updated in future publishes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants