Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

Commit

Permalink
Added preventDefault.
Browse files Browse the repository at this point in the history
  • Loading branch information
orangemug committed Feb 17, 2014
1 parent 8443b4f commit 3d7969c
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 0 deletions.
1 change: 1 addition & 0 deletions lib/delegate.js
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,7 @@ Delegate.prototype.handle = function(event) {
// false
if (returned === false) {
event[EVENTIGNORE] = true;
event.preventDefault();
return;
}
}
Expand Down
22 changes: 22 additions & 0 deletions test/tests/delegateTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,28 @@ buster.testCase('Delegate', {

delegate.off();
},
'Returning false from a callback should preventDefault': function(done) {
var delegate = new Delegate(document.body);

var spyA = this.spy();

delegate.on("click", '#delegate-test-clickable', function(event) {
spyA();

setTimeout(function() {
assert.equals(event.defaultPrevented, true);
done();
}, 0);

return false;
});

var element = document.getElementById('delegate-test-clickable');
element.dispatchEvent(setupHelper.getMouseEvent("click"));

assert.calledOnce(spyA);
delegate.off();
},
'Returning false from a callback should stop propagation globally': function() {
var delegateA = new Delegate(document), delegateB = new Delegate(document);

Expand Down

0 comments on commit 3d7969c

Please sign in to comment.