This repository has been archived by the owner on Jun 9, 2022. It is now read-only.
Carousel ui #14
Merged
Carousel ui #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </div> | ||
| </FORM> | ||
| </P> | ||
| <FORM id="carouselForm" action="/generators/carousel" method="get"> | ||
| <DIV><I>(A descriptive name for when this carousel<BR/>is listed the admin screen)</I></DIV> | ||
| <div class="url-and-duration o-forms-group"> | ||
| <DIV><I>(A descriptive name for when this carousel is listed the admin screen)</I></DIV> |
There was a problem hiding this comment.
(A descriptive name for when this carousel is listed in the admin screen)
|
LGTM (Looks good to me) 👍 |
|
If I generate a carousel URL, and then copy that URL and paste it into the paste URL box at the top of th admin without reloading the page, the form appends the items to existing carousel, rather than building it from scratch, effectively duplicating the carousel within itself. |
|
That is intentional behaviour allowing easy adding one carousel to another. I am also addressing the following concerns: Clear paste box on paste |
|
Cool, happy to give it another look over when you've got that done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #2 and some improvements on #1 which is
solved already so should be closed but this pr
makes a few further improvements.