Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize on a single marker name: "order" #38

Open
fmoor opened this issue May 26, 2017 · 3 comments
Open

Standardize on a single marker name: "order" #38

fmoor opened this issue May 26, 2017 · 3 comments

Comments

@fmoor
Copy link

fmoor commented May 26, 2017

Reading the documentation I noticed that there are a lot of potential marker names including run(), and even custom markers proposed in #10. It seems like this has the potential to result in confusing code. Say for instance that some one is new to a project and doesn't know about pytest-ordering. What does the run marker do? Run is a very ambiguous word. I would like to suggest choosing a more specific name. As an option order might be a more intuitive name for someone reading code. The marker signature might look like this: order(pos=None, before=None, after=None).

@ftobia
Copy link
Owner

ftobia commented May 29, 2017

Calling the marker order sounds like a good idea.

@ftobia ftobia changed the title marker name Standardize on a single marker name: "order" Oct 9, 2019
@ftobia
Copy link
Owner

ftobia commented Oct 9, 2019

I've updated the title to describe the proposal. I think a single marker name that takes parameters is a good idea -- though I'm interested to hear feedback from folks if you agree or disagree.

@mrbean-bremen
Copy link

mrbean-bremen commented Oct 24, 2020

I like this, and I implemented this in my fork, removing all other special markers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants