Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove _get_entity_type method from advanced base class #2

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix: remove _get_entity_type method from advanced base class #2

merged 1 commit into from
Oct 11, 2023

Conversation

hdd
Copy link
Contributor

@hdd hdd commented Oct 17, 2022

Resolves CLICKUP-2ejccbe

  • I have added automatic tests where applicable
  • The PR title is suitable as a release note
  • The PR contains a description of what has been changed
  • The description contains manual test instructions

Changes

remove reimplemented _get_entity_type from AdvancedBaseAction and rely on baseclass implementation.

Test

Not really , just ensure it does pick up the base class

@hdd hdd requested a review from a team as a code owner October 17, 2022 12:57
@hdd hdd changed the title fixes : remove _get_entity_type method from advanced base class fix: remove _get_entity_type method from advanced base class Oct 31, 2022
lluisFtrack
lluisFtrack approved these changes Jul 21, 2023
View reviewed changes
Copy link

@lluisFtrack lluisFtrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdd hdd merged commit 1ab684d into main Oct 11, 2023
@hdd hdd deleted the backlog/remove-duplicated_get_entity_type branch October 11, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lluisFtrack lluisFtrack lluisFtrack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hdd @lluisFtrack