Feat: add ci for pypi releaes #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lluisFtrack
previously approved these changes
Jul 21, 2023
lluisFtrack
reviewed
Jul 21, 2023
.github/workflows/cicd.yml
Outdated
| branches: | ||
| - main | ||
| tags: | ||
| - "v*" |
There was a problem hiding this comment.
We have to align the tags with other repositories. Double check this with Jimmy.
There was a problem hiding this comment.
@lluisFtrack do you have any other repo to point me to so I can compare ?
Thanks.
|
Sorry, lets wait until next week to approve this, I would like to talk with Mattias before publishing this to PyPI, is it something that we are already doing? Just want him to be aware of it. |
|
@lluisFtrack |
update github action to include any tag update release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add github workflow to release code on pypi .
The release will be done whenever code is tagged with v