Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Check for errors before parsing api json response #12

Merged
merged 3 commits into from Apr 5, 2023
Merged

fix: Check for errors before parsing api json response #12

merged 3 commits into from Apr 5, 2023

Conversation

nemanjab17
Copy link
Contributor

Resolves FT-38746011-2443-478e-990a-e8507efad720

  • I have added automatic tests where applicable.
  • The PR contains a description of what has been changed.
  • The description contains manual test instructions.
  • The PR contains updates to the release notes.
  • I have verified that the documentation is still up to date.

Changes

Add a check for error statuses before parsing json response, which fails otherwise since errors are not json formated.

Test

@nemanjab17 nemanjab17 requested a review from a team as a code owner March 6, 2023 12:17
@nemanjab17 nemanjab17 changed the title Check for errors before parsing api json response fix: Check for errors before parsing api json response Mar 6, 2023
@nemanjab17 nemanjab17 force-pushed the backlog/improve-server-error-parsing branch 2 times, most recently from 1dee5ad to f431ce2 Compare March 6, 2023 12:27
@nemanjab17 nemanjab17 force-pushed the backlog/improve-server-error-parsing branch from f431ce2 to 72de443 Compare March 6, 2023 12:39
octavian-ionescu
octavian-ionescu approved these changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@octavian-ionescu octavian-ionescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@nemanjab17
Copy link
Contributor Author

nemanjab17 commented Mar 6, 2023 •
edited

@octavian-ionescu I added PR workflow that was missing with Jimmy's help

torsdag
torsdag approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@torsdag torsdag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@torsdag torsdag merged commit 95a8455 into main Apr 5, 2023
10 of 11 checks passed
@torsdag torsdag deleted the backlog/improve-server-error-parsing branch April 5, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torsdag torsdag torsdag approved these changes

@octavian-ionescu octavian-ionescu octavian-ionescu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nemanjab17 @torsdag @octavian-ionescu