Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Backlog/remove python 2 traces #35

Merged
merged 18 commits into from Mar 22, 2024
Merged

chore: Backlog/remove python 2 traces #35

merged 18 commits into from Mar 22, 2024

Conversation

torsdag
Copy link
Contributor

@torsdag torsdag commented Mar 15, 2024 •
edited

Resolves

  • I have added automatic tests where applicable.
  • The PR contains a description of what has been changed.
  • The description contains manual test instructions.
  • The PR contains updates to the release notes.
  • I have verified that the documentation is still up to date.

Changes

  • remove six as a dependency
  • remove future as a dependencyu
  • remove backported WeakMethod implemtnation
  • remove usage of future.utils.with_metaclass

Test

@torsdag torsdag marked this pull request as ready for review March 18, 2024 10:38
@torsdag torsdag requested a review from a team as a code owner March 18, 2024 10:38
octavian-ionescu
octavian-ionescu previously approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@octavian-ionescu octavian-ionescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

octavian-ionescu
octavian-ionescu previously approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@octavian-ionescu octavian-ionescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

octavian-ionescu
octavian-ionescu approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@octavian-ionescu octavian-ionescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@torsdag torsdag merged commit 5a54da9 into main Mar 22, 2024
8 checks passed
@torsdag torsdag deleted the backlog/remove-python-2-traces branch March 22, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octavian-ionescu octavian-ionescu octavian-ionescu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@torsdag @octavian-ionescu