Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Eufy Security WS Add On to 0.5.2 (latest) #59

Closed
fuatakgun opened this issue Sep 19, 2021 · 29 comments
Closed

Update Eufy Security WS Add On to 0.5.2 (latest) #59

fuatakgun opened this issue Sep 19, 2021 · 29 comments
Assignees

Comments

@skank01
Copy link

skank01 commented Oct 18, 2021

Theres a new version 0.5.0
https://github.com/bropat/eufy-security-ws/releases/tag/0.5.0

It adds Added new commands startRTSPLivestream, stopRTSPLivestream and isRTSPLiveStreaming to Station

  • new driver

@fuatakgun fuatakgun changed the title Update Eufy Security WS Add On to 0.4.2 (latest) Update Eufy Security WS Add On to 0.5.0 (latest) Oct 18, 2021
@fuatakgun
Copy link
Owner Author

fuatakgun commented Oct 18, 2021

i am not worried about RTSP functionality, at least, it will not contribute to p2p. RTSP has been working steady since beginning, because it is camera's responsibility to generate the stream, not add-on or integration

@skank01
Copy link

skank01 commented Oct 19, 2021

i am not worried about RTSP functionality, at least, it will not contribute to p2p. RTSP has been working steady since beginning, because it is camera's responsibility to generate the stream, not add-on or integration

Yeah mm, well, here and others dont have the rtsp stable either... especially starting/stopping

@fuatakgun
Copy link
Owner Author

İ don't have any open issues regarding reliability of rtsp anywhere. Happy to investigate, if there is any.

@skank01
Copy link

skank01 commented Oct 21, 2021

Well,, see the HA community topic, i'm not the only one saying its not stable for us...
But i still think, updating to WS addon 0.5.0 might solve some stuff for us..
So looking forward to this enhancement ;)

@fuatakgun
Copy link
Owner Author

Can you please point some?

@skank01
Copy link

skank01 commented Oct 21, 2021

Sure, ask conorlap :) he's experiencing the same stuff as me
It was good for one hour, then nothing than trouble starting/stopping, streaming...

@fuatakgun
Copy link
Owner Author

fuatakgun commented Oct 21, 2021

can you point the issue about RTSP please? if you don't remember or don't know, no need to discuss further.
I am also an active user of RTSP and it is moving forward well. I am aware about P2P streaming issues, but they are well separated between RTSP and P2P.

as you can see, I am tracking this upgrade as an issue here, so it is also important for me. Moreover, I am directly in touch with bropat about the issues and fixes. If you want to contribute to discussion, you are more than welcome.

If you want to be more up to date, follow up issues in eufy-security-ws and eufy-security-client repositories, I am creating multiple issues here and there

@skank01
Copy link

skank01 commented Oct 21, 2021

Well stopping the rtsp is a problem.. first it responds, but then after x time, i can press as much as i want to stop it, it doesnt stop
Playing the rtsp is better now on latest version...

P2P is buffering a lot (although using the rtsp addon) and sometimes starting/stopping is not working as well.

If you want me to help discuss with you and bropat, sure point me to the right stuff.
I will see if i can contribute anything
Edit; i'm willing to contribute in the ws and client repositories of bropat, but to do so, i think we should be on same last version first? No?

@skank01
Copy link

skank01 commented Oct 22, 2021

So i'm very eager to wait for this 0.5.0
Do you have any ETA in your mind for this?

@fuatakgun
Copy link
Owner Author

Follow open issues in ws and client repositories created by me

@skank01
Copy link

skank01 commented Oct 23, 2021

0.5.1 out based on client 1.2.1
https://github.com/bropat/eufy-security-ws/releases/tag/0.5.1

Client changes:
(bropat) Changed event detection for start/stop local RTSP streaming
(bropat) Fixed regression introduced by fixing issue #51
(bropat) Fixed new implementation that detects interrupted p2p streams
(bropat) Fixed missing start/stop local RTSP streaming commands to hasCommand and getCommands

@fuatakgun
Copy link
Owner Author

As i informed you earlier, i am following up all updates from respective repositories, no need to publish them here.

@skank01
Copy link

skank01 commented Oct 23, 2021 via email

@boudicca99
Copy link

boudicca99 commented Nov 1, 2021

good morning, any chance of a "how to update/upgrade" with gui instructions. Have stable 0.3.3 run under HACS/Docker but nearly broke it trying to guess the how to upgrade....gets very confusing whether this is an upgrade process via docker cli or can it be done thru the HACS/HA GUI ? Please and Thanks Shaz

@fuatakgun fuatakgun changed the title Update Eufy Security WS Add On to 0.5.0 (latest) Update Eufy Security WS Add On to 0.5.1 (latest) Nov 4, 2021
@fuatakgun
Copy link
Owner Author

fuatakgun commented Nov 4, 2021

main post is updated with all issues and improvements
targeted version number (0.5.1) is updated

@fuatakgun fuatakgun changed the title Update Eufy Security WS Add On to 0.5.1 (latest) Update Eufy Security WS Add On to 0.5.2 (latest) Nov 7, 2021
@fuatakgun
Copy link
Owner Author

fuatakgun commented Nov 7, 2021

targeted version number (0.5.2) is updated

@fuatakgun
Copy link
Owner Author

with new version of add-on and integration, I am able to stream over p2p without time limit, I have tested up to 15 minutes

@skank01
Copy link

skank01 commented Nov 7, 2021

Cool wonder how good it is... curious about the loading part :)
Many bugsfixing in it :)

@fuatakgun
Copy link
Owner Author

I hope i will publish it today, i am worried about migration as new integration version is tightly coupled with new add-on version.

If a user updates their add-on, they should not skip integration update and vice versa.

I will rely on announcing through home assistant forum, let's see how it goes

@skank01
Copy link

skank01 commented Nov 7, 2021

Today? Wauw great! Didnt expect that.
Am i right, a lot changed ? You need to update the readme? I'm not sure if the rtsp server addon is still needed too?
And if webrtc is still needed

@skank01
Copy link

skank01 commented Nov 10, 2021

I hope i will publish it today, i am worried about migration as new integration version is tightly coupled with new add-on version.

If a user updates their add-on, they should not skip integration update and vice versa.

I will rely on announcing through home assistant forum, let's see how it goes

Hey, something went wrong?
Ur ok?

@fuatakgun
Copy link
Owner Author

updated both add-on and integration, please give it a try, YOU MUST UPDATE BOTH OF THEM.

@fuatakgun
Copy link
Owner Author

fuatakgun commented Nov 14, 2021

add-on version: 0.5.2
integration version: e7c7f05
image

image

@auspokey
Copy link

Updated add-on to 0.5.2 and latest integration and now I am getting the following error in the logs of the Add-on:
image

@Freddan101
Copy link

Updated add-on to 0.5.2 and latest integration and now I am getting the following error in the logs of the Add-on:
image

I'm getting the same error. The push notifications work, but no camera entity is created. The base station device is not created, just the doorbell.

@skank01
Copy link

skank01 commented Nov 15, 2021

I'm not seeing that error.
I'm seeing connection established
And 4 times client disconnected with ip X port: 42018 code: 1006 reason:
All the devices are still there, here

@fuatakgun
Copy link
Owner Author

please track here about length issue: bropat/eufy-security-ws#44
@Freddan101 @auspokey

@fuatakgun
Copy link
Owner Author

I will resolve this, you can create separate issues after we have a traction from @bropat about this: bropat/eufy-security-ws#44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants