vnet: special-case vnet="inherit" when in save #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-VNET jails have vnet="inherit" set on them by the kernel. When recreating these e.g. using RunningJail::restart(), this creates problems, especially when IP address restrictions are set. For now, we drop vnet="inherit" params when saving, so that non-VNET jails stay non-VNET when restarted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-VNET jails have
vnet="inherit"set on them by the kernel. Whenrecreating these e.g. using
RunningJail::restart(), this createsproblems, especially when IP address restrictions are set.
For now, we drop
vnet="inherit"params when saving, so that non-VNETjails stay non-VNET when restarted.