Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GET in php 8.2 sometimes has null values #2206

Open
wants to merge 2 commits into
base: 1.9/develop
Choose a base branch
from
Open

GET in php 8.2 sometimes has null values #2206

wants to merge 2 commits into from

Conversation

Thunder-Dan
Copy link
Contributor

No description provided.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@WanWizard
Copy link
Member

WanWizard commented Feb 1, 2024 •
edited

Do you have an example? And why specific to PHP 8.2?

Also, there should be a space between if and bracket if ( as per the coding standards.

And indentation still doesn't seem rights (tabs, not spaces), see https://github.com/fuel/core/blob/ea46e3291ad4bdb88f1bd59390cbae9c20a5273b/classes/security.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Thunder-Dan @WanWizard