PHP 8.1 compatability when phpunit autoload file doesnt exit #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oil attempts to load phpunits autoload file, ignoring failures if it isn't able to load the file. The code was using the @ operator to supress errors in loading the file. This change will check if the file exists as a gate in front of loading it, which will prevent the error that is no longer supressed in php 8.1
|
SonarCloud Quality Gate failed.
|
|
Whew, code smell red flags all over the existing code. @WanWizard I'd be happy to fix those in another PR if that's desirable? |
|
As an alternative, I was able to work around the error by setting the config for |
|
Sorry for the late reply, Covid finally caught up with me, feeling rather poorly. Most of the "code smells" are related to "Move this open curly brace to the end of the previous line", which is a Fuel code standard. So SonarCloud needs tweaking at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oil attempts to load phpunit's autoload file, ignoring failures if it isn't able to load the file. The code is currently using the @ operator to suppress errors in loading the file.
Here's the error caused by running phpUnit on https://github.com/ucfopen/Materia on php 8.1
This change will check if the file exists as a gate in front of loading it, which will prevent the error that is no longer suppressed in php 8.1