Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add :border_tag option to Owl.Box.new/2 #7

Merged
merged 1 commit into from
Feb 11, 2023
Merged

Conversation

zachallaun
Copy link
Contributor

:border_tag can be a sequence/sequences that, if present, will be passed to Owl.Data.tag/2 and used to wrap the symbols that make up box borders. This allows you to stylize the border without having to tag the entire box and ensure that all contents are also tagged.

Note: I also edited one doctest in f8b1549 to better support editors that are configured to automatically strip trailing whitespace on save. If you'd prefer to leave it as-is, I'm happy to rebase this PR to remove that commit.

@fuelen
Copy link
Owner

fuelen commented Feb 10, 2023

@zachallaun I'd be happy to merge the PR, but please drop the commit related to newlines. I think editors should have disabled automatic stripping of trailing whitespaces. They should be integrated with mix formater instead :) It does the job well and doesn't strip whitespaces in strings.

@zachallaun
Copy link
Contributor Author

Fair enough! Rebased & pushed.

@fuelen fuelen merged commit bae3db4 into fuelen:main Feb 11, 2023
@fuelen
Copy link
Owner

fuelen commented Feb 11, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants