Skip to content
This repository has been archived by the owner on Feb 28, 2022. It is now read-only.

Simplify block header verify to just compare hashes #16

Closed
adlerjohn opened this issue Jul 8, 2020 · 1 comment · Fixed by #18
Closed

Simplify block header verify to just compare hashes #16

adlerjohn opened this issue Jul 8, 2020 · 1 comment · Fixed by #18
Assignees
@SilentCicero
Labels
bug Something isn't working

Comments

@adlerjohn
Copy link
Contributor

adlerjohn commented Jul 8, 2020 •
edited
Loading

Verifying the block header is not actually be needed, as it's verified on commitment. Simply hashing the header and comparing it to the known header hash at that height is be sufficient. The checks before that can be removed.
@adlerjohn adlerjohn added the bug Something isn't working label Jul 8, 2020
@SilentCicero
Copy link
Member

#18

@adlerjohn adlerjohn linked a pull request Jul 9, 2020 that will close this issue
Simplified Header Checks, TODOs, Token ID Constraints, WitnessCommitted Event, HTLC #18
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SilentCicero SilentCicero

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@adlerjohn @SilentCicero