You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are a few PRs currently failing on CI due to the failure to dynamically fetch istanbul for code coverage. This doesn't happen consistently though.
The message may be misleading, as the logs the following errors are present:
Module "child_process" has been externalized for browser compatibility. Cannot access "child_process.spawn" in client code. See https://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.Module "child_process" has been externalized for browser compatibility. Cannot access "child_process.exec" in client code. See https://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.
This appears to have been introduced in the following PR (based upon the CI failures):
Indeed child_process will not work in browser. When bundling, every time vite identifies that dep it'll give that warning. However, we should be dynamically importing it everywhere it is actually needed in tests. I'd expect it to throw on that line otherwise, like it did in the past before we had a dynamic import.
There are a few PRs currently failing on CI due to the failure to dynamically fetch istanbul for code coverage. This doesn't happen consistently though.
Here are a few affected PRs:
The text was updated successfully, but these errors were encountered: