Allow unfree packages in flake?

[fufexan]

The current mechanism doesn't include that, but we do provide packages with unfree licenses, such as osu-lazer-bin, and maybe others in the future.

Should we enable allowUnfree in this flake, and implicitly in users' flake configs? Or should we leave it as is, requiring users to add
NIXPKGS_ALLOW_UNFREE=1 nixos-rebuild ... --impure when building?

[MagicRB]

No you should make it configurable IMO, definitely not allow by default. By default IMO osu-lazer-bin should be disabled too, it should be opt in with a fat warning.

[fufexan]

Sure! Any idea how I could make something like that (using something like nix-gaming.allowUnfree, like the nixpkgs mechanism)?

[MagicRB]

I'll take a look at the code.

[fufexan]

Take a look at the rewritten flake branch for a utils-free flake that may make implementing this easier.

[MagicRB]

I just wanted to say how much I hate fup but removing it won't help in this case. We need a functions somewhere Bool -> Something there are two places, in the outputs which would make the whole CLI break for nix-gaming or inputs

[fufexan]

Following the decision that only packages would be affected by the change, I'll enable unfree packages.