-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic DXVK builder and installer #7
Conversation
Signed-off-by: Magic_RB <magic_rb@redalder.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Could you run nixpkgs-fmt
over the files?
@@ -21,6 +21,10 @@ in | |||
|
|||
winestreamproxy = prev.callPackage ./winestreamproxy { wine = final.wine-tkg; }; | |||
|
|||
dxvk-x64 = prev.callPackage ./dxvk { }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add these in alphabetical order.
(dxvk-async + "/dxvk-async.patch") | ||
]; | ||
|
||
# NIX_CFLAGS_COMPILE = "-I ${wineWowPackages.staging}/include/wine/windows"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed anymore?
README: update documentation
WINEPREFIX=''${WINEPREFIX:-"$HOME/.wine"} | ||
|
||
. ${setupScript} | ||
cp -v ${pkgsCross.mingwW64.windows.mcfgthreads}/bin/mcfgthread-12.dll "$WINEPREFIX/dosdevices/c:/windows/syswow64/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these the right way around? On native windows Syswow64 contains the 32 bit DLLs and system32 the 64 bit ones, despite that sounding backwards.
AFAIC mingwW64 is for the 64bit ones so it shouldn't go in syswow64.
@MagicRB Are you still interested in this? If not I'd like to start with what you have and finish it up |
I am but i dont habe time for it, you can take it over. @LunNova |
Finished in #42. Thank you both! |
Signed-off-by: Magic_RB magic_rb@redalder.org
The installer needs work, I'll get to it eventually