Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic DXVK builder and installer #7

Closed
wants to merge 1 commit into from

Conversation

MagicRB
Copy link
Contributor

@MagicRB MagicRB commented Dec 14, 2021

Signed-off-by: Magic_RB magic_rb@redalder.org

The installer needs work, I'll get to it eventually

Signed-off-by: Magic_RB <magic_rb@redalder.org>
Copy link
Owner

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Could you run nixpkgs-fmt over the files?

@@ -21,6 +21,10 @@ in

winestreamproxy = prev.callPackage ./winestreamproxy { wine = final.wine-tkg; };

dxvk-x64 = prev.callPackage ./dxvk { };
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add these in alphabetical order.

(dxvk-async + "/dxvk-async.patch")
];

# NIX_CFLAGS_COMPILE = "-I ${wineWowPackages.staging}/include/wine/windows";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed anymore?

PedroHLC pushed a commit to PedroHLC/nix-gaming that referenced this pull request Sep 2, 2022
README: update documentation
WINEPREFIX=''${WINEPREFIX:-"$HOME/.wine"}

. ${setupScript}
cp -v ${pkgsCross.mingwW64.windows.mcfgthreads}/bin/mcfgthread-12.dll "$WINEPREFIX/dosdevices/c:/windows/syswow64/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these the right way around? On native windows Syswow64 contains the 32 bit DLLs and system32 the 64 bit ones, despite that sounding backwards.

AFAIC mingwW64 is for the 64bit ones so it shouldn't go in syswow64.

@LunNova
Copy link
Contributor

LunNova commented Nov 2, 2022

@MagicRB Are you still interested in this? If not I'd like to start with what you have and finish it up

@MagicRB
Copy link
Contributor Author

MagicRB commented Nov 2, 2022

I am but i dont habe time for it, you can take it over. @LunNova

@fufexan
Copy link
Owner

fufexan commented Dec 4, 2022

Finished in #42. Thank you both!

@fufexan fufexan closed this Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants