Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destroys expired messages daily #51

Merged
merged 7 commits into from
Jun 29, 2016

Conversation

trevormast
Copy link
Contributor

Addresses #42

Needs configuration for redis in production.

  1. Whenever schedules rake task 'message_task:check_expiry'
  2. rake task initiates Sidekiq worker to delete expired messages

Adds specs to cover each.

@amoose
Copy link
Member

amoose commented Feb 13, 2016

Testing 🏁

@trevormast Can you rebase and push again to trigger a new Travis build? Thanks!

@trevormast
Copy link
Contributor Author

Done! 🐐

@@ -18,6 +18,8 @@ gem 'slim-rails'
gem 'therubyracer'
gem 'thin'
gem 'whenever'
gem 'sidekiq'
gem 'sinatra'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can move this to the :development group since it's only needed for the Sidekiq dashboard which we only set routes for in the dev env.

@coveralls
Copy link

coveralls commented Jun 26, 2016

Coverage Status

Coverage increased (+0.7%) to 95.495% when pulling ee45329 on trevormast:feature/destroy_expired into a0bffee on fugacious:dev.

@trevormast
Copy link
Contributor Author

@jgrevich good call. Made changes and rebased!

@jgrevich jgrevich self-assigned this Jun 29, 2016
@jgrevich
Copy link
Member

Awesome stuff, thanks @trevormast! 🎉

My apologies for taking so long to get to this. I'm just beginning to pickup work on this project and will be more responsive going forward.

@jgrevich jgrevich merged commit a582150 into fugacious:dev Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants