Adds bin/setup and Procfile #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoose
force-pushed
the
amos/fix/setup
branch
from
d6b407b
to
c99a928
Compare
amoose
force-pushed
the
amos/fix/setup
branch
from
c99a928
to
91c6705
Compare
1 similar comment
jmcarp
reviewed
Nov 2, 2016
| @@ -0,0 +1,2 @@ | |||
| web: bundle exec puma -t 5:5 -p ${PORT:-3000} -e ${RACK_ENV:-development} | |||
There was a problem hiding this comment.
We also have this configuration in config/puma.rb, using it in bin/cf-start.
There was a problem hiding this comment.
Procfile is required for foreman and Heroku; does this collide with config/puma.rb ?
There was a problem hiding this comment.
What I'm suggesting is something like:
web: bundle exec puma -C config/puma.rb
...as in bin/cf-start.
There was a problem hiding this comment.
AH -- yes, I think that is the correct approach. I will update!
|
Updated Procfile @jmcarp and tested on Heroku 🚀 |
line47
pushed a commit
that referenced
this pull request
Feb 13, 2017
* Adds bin/setup and procfile * Updates README formatting * Updates Procfile to read from puma.rb
jgrevich
pushed a commit
that referenced
this pull request
Nov 1, 2017
* Adds bin/setup and procfile * Updates README formatting * Updates Procfile to read from puma.rb
amoose
added a commit
that referenced
this pull request
Nov 6, 2017
* Adds bin/setup and procfile * Updates README formatting * Updates Procfile to read from puma.rb
amoose
added a commit
that referenced
this pull request
Nov 6, 2017
* Adds bin/setup and procfile * Updates README formatting * Updates Procfile to read from puma.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes bin/setup and Procfile from my original PR