Skip to content

Commit

Permalink
Update for codespace (#49)
Browse files Browse the repository at this point in the history
* update

* update
  • Loading branch information
goodwanghan committed Sep 29, 2020
1 parent ce54df6 commit 1729fab
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ RUN if [ "${INSTALL_NODE}" = "true" ]; then su vscode -c "source /usr/local/shar

# [Optional] If your pip requirements rarely change, uncomment this section to add them to the image.
# COPY requirements.txt /tmp/pip-tmp/
# RUN pip3 --disable-pip-version-check --no-cache-dir install -r /tmp/pip-tmp/requirements.txt \
# && rm -rf /tmp/pip-tmp
RUN pip3 install jupyter \
&& rm -rf /tmp/pip-tmp

# [Optional] Uncomment this section to install additional OS packages.
# RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
Expand Down
8 changes: 6 additions & 2 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@
"extensions": [
"ms-python.python"
],
"forwardPorts": [],
"postCreateCommand": "pip3 install -r requirements.txt"
"forwardPorts": [
8888
],
"postCreateCommand": [
"make devenv"
]
}
6 changes: 2 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,8 @@ help:
@echo " test run all tests with coverage (assumes venv is present)"

devenv:
python3 -m venv venv
venv/bin/pip install -r requirements.txt
venv/bin/pre-commit install
venv/bin/pre-commit run --all-files
pip3 install -r requirements.txt
pre-commit install

dev:
pip3 install -r requirements.txt
Expand Down

0 comments on commit 1729fab

Please sign in to comment.