Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fatal function may impede the downstream APIs functionality #303

Open
Raviteja-Ainampudi opened this issue May 28, 2021 · 0 comments
Open

Comments

@Raviteja-Ainampudi
Copy link

sys.exit(1)

I suggest removing the os.exit(1) because, it might hinder the functionality of any downstream API.
I'm not sure, if that line of code will actually help the functionality of Credstash.

My experience:
I was trying to use Credstash in AWS lambda, and need to extract passwords for a list of keys. But, this sys.exit(1) causes the whole lambda to exit. Ofcourse, I can change the source code. But I want to suggest this such that the scope of Credstash can be improved among the developer community. If anybody is having Credstash among their Upstream APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant