Add support for marshmallow_union and marshmallow_enum #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @coreydexter don't know if you noticed, but I opened a pull request for your fork that completes the coverage. Take a look 😉 |
Completed coverage for union and enum support
|
Thanks @hadasarik ! |
|
Nice work!! Thanks @coreydexter and @hadasarik!! |
|
No worries @fuhrysteve. Did you have plans to do a release on pypi soon? It would be great to be able to use this and the othe recent changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional support for marshmallow_union and marshmallow_enum.
This will provide useful integration with the marshmallow_dataclass package which also utilises these packages and makes setting up marshmallow schemas easy.