Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: buggy code in colors sample #126

Merged
merged 1 commit into from
Nov 21, 2020
Merged

fix: buggy code in colors sample #126

merged 1 commit into from
Nov 21, 2020

Conversation

abcdenis
Copy link
Contributor

@abcdenis abcdenis commented Nov 5, 2020

hex(5)
'0x5'

so rgb(1,2,33) will result in "#1221" which is strange

@abcdenis
fix: buggy code in colors sample
f983d81 
>>> hex(5)
'0x5'

so rgb(1,2,33) will result in "#1221" which is strange
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f983d81 on abcdenis:patch-2 into 3f49816 on fuhrysteve:master.

@fuhrysteve fuhrysteve merged commit efc4dc8 into fuhrysteve:master Nov 21, 2020
@fuhrysteve
Copy link
Owner

haha makes sense! thanks for the pull!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abcdenis @coveralls @fuhrysteve