Add support for title and description metadata #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor _resolve_additional_properties to reuse parts of it for title and description support - Add _get_schema_metadata that retrieves the 3 currently supported metadata options on a schema - Rename 'cls' params to something less confusing as 'cls' is a python keyword - Add documentation for title, description and additional_properties - Move addtional_properties tests to a new forlder "schema_metadata_tests" so they can be gathered in a common place Closes fuhrysteve#41
|
I'm unsure what to do with the CI issues. I can apply Any pointers @fuhrysteve ? |
|
Bump - any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title and description support
metadata options on a schema
keyword
"schema_metadata_tests" so they can be gathered in a common place
Closes #41