ConcurrentModificationException on remove you

[BiggA94]

To reproduce:
The following generates a Concurrent Modification Exception:

@Test
public void testRemoveObj(){
   University uni = new University().withName("UniKasselVersitaet");
   Student student1 = uni.createStudents().withName("Peter");
   Student student2 = uni.createStudents().withName("Paul");
   Student student3 = uni.createStudents().withName("Mary");

   IdMap idMap = UniversityCreator.createIdMap("u");
   idMap.toJsonArray(uni);
   uni.removeYou();
}

One solution for this problem is to remove

Collection<?> continee = (Collection<?>) reference;
Iterator<?> i = continee.iterator();
while (i.hasNext()) {
   creator.setValue(oldValue, prop, i.next(),
   SendableEntityCreator.REMOVE);
}

and replace it with

Object[] array = ((Collection) reference).toArray();
for (int i = 0; i < array.length; i++) {
   Object object = array[i];
   creator.setValue(oldValue, prop, object,
   SendableEntityCreator.REMOVE);
}

(IdMap, line 422ff)
This works for newly generated Models but not for the one, that is inside the test-package.
And it is also slower.

[ghost]

Your issue doesn't follow our guidelines. Please fix the following:

• Issue must have at least one label (?)

Click here for details.

Thank you! 🙏

_{This comment was made by GitMagic – Magically enforcing your contribution guidelines.}

[ghost]

This issue still violates some of our guidelines:

• Issue description must include reproduction steps (?)

Click here for details.

[ghost]

This issue still violates some of our guidelines:

• Issue description must include reproduction steps (?)

Click here for details.

[ghost]

This issue still violates some of our guidelines:

• Issue description must include reproduction steps (?)

Click here for details.

[ghost]

Thank you, everything looks good now!

[StefanLindel]

Use a SimpleIterator for moving over a Collection