Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant mandatory check #15

Merged
merged 1 commit into from Sep 26, 2017

Conversation

okkez
Copy link
Contributor

@okkez okkez commented Jun 2, 2017

No description provided.

@okkez
Copy link
Contributor Author

okkez commented Sep 26, 2017

config_param :zabbix_server, :string means that Fluentd will check parameter zabbix_server is mandatory on boot.
So removed code in this PR is redundant.

@fujiwara Do you have any concern?

@fujiwara
Copy link
Owner

Thank you.
Certainly, Fluentd raises Fluent::ConfigError when zabbix_server is not specified.

<match ping.**>
  @type zabbix
  host "localhost"
  name_key_pattern "."
</match>

2017-09-26 15:13:22 +0900 [error]: config error file="fluentd.conf.zabbix" error_class=Fluent::ConfigError error="'zabbix_server' parameter is required"

@fujiwara fujiwara merged commit 3347ba1 into fujiwara:master Sep 26, 2017
@okkez
Copy link
Contributor Author

okkez commented Sep 26, 2017

Thank you!!

@okkez okkez deleted the remove-redundant-mandatory-check branch September 26, 2017 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants