fix STREAM-UNREAD-CHAR #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In STREAM-READ-CHAR, the first value returned from the BABEL:CODE-POINT-COUNTER function was used to track LAST-CHAR-SIZE (the number of bytes consumed while reading a character). However, it is actually the number of characters decoded, and for this particular call, it is always 1. As a result, a later STREAM-UNREAD-CHAR of a multibyte character will cause BUFFER-POSITION to point into the middle of the encoded byte sequence, ultimately leading to a decoding error. Instead, use the second value returned from the BABEL:CODE-POINT-COUNTER function, the position in the buffer to start the next decoding, and compute LAST-CHAR-SIZE using its difference from BUFFER-POSITION.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In STREAM-READ-CHAR, the first value returned from the
BABEL:CODE-POINT-COUNTER function was used to track
LAST-CHAR-SIZE (the number of bytes consumed while reading a
character). However, it is actually the number of characters decoded,
and for this particular call, it is always 1. As a result, a later
STREAM-UNREAD-CHAR of a multibyte character will cause BUFFER-POSITION
to point into the middle of the encoded byte sequence, ultimately
leading to a decoding error.
Instead, use the second value returned from the
BABEL:CODE-POINT-COUNTER function, the position in the buffer to start
the next decoding, and compute LAST-CHAR-SIZE using its difference
from BUFFER-POSITION.