Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

declare type of step in advance*. #4

Closed
wants to merge 1 commit into from

Conversation

rudolph-miller
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 92.37% when pulling 426c59e on Rudolph-Miller:optimize into cc80bb6 on fukamachi:master.

@fukamachi
Copy link
Owner

I don't get why this change has to be in. The step could be a symbol or a form.

@rudolph-miller
Copy link
Contributor Author

with (declare (speed 3) (safety 0) (debug 0)) compiler said step is uncertain.
Can step be symbol or form?

@fukamachi
Copy link
Owner

Yes, cause advance* is a macro.

You're declaring it compile-time. If the warning disappears by this, it's not important, just you're making it unsafe expansion.

Are there any differences in performance?

@rudolph-miller
Copy link
Contributor Author

I know it has no influence on performance and it's just matter of compilation time.
I wanna just remove warnings.
Does the change make it unsafer?

@fukamachi
Copy link
Owner

There must be other warnings in compile-time too. Declaring speed 0 in the macros would work, I think.

@rudolph-miller
Copy link
Contributor Author

Really?
I can not remove warnings with speed 0 in macros.
Anyway, I can ignore the warnings with compilation time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants