Expanded mutation interface. Created pessimistic mutation ns. Added more docs. #4
Conversation
|
Wilker, I'd appreciate you glancing at the new pessimistic mutation ns and seeing if it needs anthying else before I release 0.0.3...in particular if it needs more renames of any kind in order to make it ok. I did a lot of name normalizing to follow fulcro standards...I think I got em all. |
README.adoc
Outdated
|
|
||
| ``` | ||
| :fulcro.incubator.pessimistic-mutations/mutation-response { | ||
| :error {:fulcro.client.primitives/error #error {:message "You screwed up!!!", :data {}}} |
There was a problem hiding this comment.
maybe this should be
| :error {:fulcro.client.primitives/error #error {:message "You screwed up!!!", :data {}}} | |
| :fulcro.incubator.pessimistic-mutations/error {:fulcro.client.primitives/error #error {:message "You screwed up!!!", :data {}}} |
There was a problem hiding this comment.
It's in embedded key in a map already keyed by a namespaced keyword...seems like overkill to me. In fact, I'd like to clean these maps up quite a bit and have much clearer meanings for things, and probably drop all nses on the internal bits.
There was a problem hiding this comment.
Oh wait, I see what you mean. This is the response from the mutation...
README.adoc
Outdated
| ``` | ||
|
|
||
| The main one to look for is the last one, which will not change. The other keys are still under refinement, but currently | ||
| the actual network error from the server (when an `ex-info` is thrown) is in the nested `:error` map. |
There was a problem hiding this comment.
then update here too if you agree
No description provided.