Add renderer for type :decimal and style :USD for form fields. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default values do not pass the test of math/numeric?, and thus are not displayed. Assumption is that this check is not needed, as the values are coming from DB, where the type constraint is applied.
|
Remind me: where was the USD thing coming up? The demo? Technically, currency formatting is a "locale" thing, so calling |
|
Nope in my project, I have attributes with :ao/style :USD, this displays
correctly in the defsc-report but does not in defsc-form.
In defsc-report there are default controls which it uses for display, while
in form it only uses installed controls. I took the USD code from the
default controls of report and integrated it with the semantic-ui controls.
…On Wed, Jun 24, 2020 at 6:44 PM Tony Kay ***@***.***> wrote:
Remind me: where was the USD thing coming up? The demo?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGG57AUKZAUDHEQSEZVDO3RYINMHANCNFSM4OFS47QQ>
.
|
|
OK, well, this is probably ok then...it is an implementation detail I can deal with later. |
|
released in 0.0.11-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
There are two commits, one is for implementing the currency rendering when the type is :decimal and :style :USD in form fields.
The second commit is a bug fix when the type is :decimal and :style :default, to allow default values to be displayed in the form.
Thanks,
Murtaza