Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: report column-styles not applied #111

Merged
merged 1 commit into from Mar 16, 2023

Conversation

yenda
Copy link
Contributor

@yenda yenda commented Mar 16, 2023

I noticed that my column-styles were not applied in my report, unless I'm mistaken this is a report option not an attribute option.

@awkay
Copy link
Member

awkay commented Mar 16, 2023

The plural version is for putting on the report itself. The singular (if I made one, column-style) is for putting on an attribute. It would make no sense at all to put the plural one on a singular attribute.

@yenda
Copy link
Contributor Author

yenda commented Mar 16, 2023

The plural version is for putting on the report itself. The singular (if I made one, column-style) is for putting on an attribute. It would make no sense at all to put the plural one on a singular attribute.

But that is what the current code is doing afaiu, it's trying to read the plural version from the attribute, so I changed that to read it from the report itself. Am I misunderstanding something here?

In my code I have the plural option in my report, current version of RAD ignores it and with this fix it works

Afaict there is no singular version of the option

@awkay
Copy link
Member

awkay commented Mar 16, 2023

sorry, I read the diff backwards!

@awkay awkay merged commit ad567a0 into fulcrologic:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants