Error if get-query in :query outside of a join #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I perhaps add a test for this case to |
awkay
reviewed
Mar 8, 2020
holyjak
force-pushed
the
feature/warn-get-query-missing-join
branch
from
17eab54
to
6497085
Compare
E.g. `:query [:my/key (comp/get-query MyChild)]` will fail with
> defsc MyComponent: `get-query` calls in :query can only be inside a join value,
> i.e. `{:some/key (comp/get-query Header)}` at ...
Note: I do not include the preceeding key so that I also catch
`:query [(get-query AnotherChild)]` and b/c I cannot know whether
it is intended as a key for the join or an unrelated property.
holyjak
force-pushed
the
feature/warn-get-query-missing-join
branch
from
6497085
to
4037185
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g.
:query [:my/key (comp/get-query MyChild)]will fail withNote: I do not include the preceeding key so that I also catch
:query [(get-query AnotherChild)]and b/c I cannot know whetherit is intended as a key for the join or an unrelated property.