Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to checking RepeatableValue type from using a private property #79

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

corporealshift
Copy link
Contributor

@corporealshift corporealshift commented Apr 4, 2024

What?

  • Switch to just importing the class where it is used.

Why?

This flag was causing problems with the media viewer (and potentially other places)
Jira issue

Testing

  • add this branch as dependency in the fulcrumapp inside fulcrum-components/package.json
    • in fulcrumapp cd lib/assets/fulcrum-components
    • yarn add fulcrumapp/fulcrum-core#bugfix/flcrm-14880/check-repeatablevalue-type && ./yarn
  • test that photos from repeatables are present in the photo gallery

NOTE TO AUTHOR: Notify Slack channel #chaos-env-updates of upcoming changes to this widely-used tool.

…g property.

This flag was causing problems with the media viewer (and potentially other places)
@corporealshift corporealshift requested a review from a team as a code owner April 4, 2024 19:34
@andres-martin andres-martin merged commit 39fb781 into main Apr 4, 2024
3 checks passed
@andres-martin andres-martin deleted the bugfix/flcrm-14880/check-repeatablevalue-type branch April 4, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants