Skip to content

Commit

Permalink
move minify closer to core build. unpkg
Browse files Browse the repository at this point in the history
  • Loading branch information
arshaw committed Mar 15, 2019
1 parent 1d75f4b commit 61a1464
Show file tree
Hide file tree
Showing 4 changed files with 45 additions and 38 deletions.
2 changes: 2 additions & 0 deletions gulpfile.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
const gulp = require('gulp')

require('./tasks/build')
require('./tasks/minify')
require('./tasks/dts')
require('./tasks/package-meta')
require('./tasks/lint')
require('./tasks/archive')

gulp.task('dist', [
'build',
'minify',
'dts',
'package-meta'
])
39 changes: 1 addition & 38 deletions tasks/archive.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
const gulp = require('gulp')
const filter = require('gulp-filter')
const modify = require('gulp-modify-file')
const uglify = require('gulp-uglify')
const cssmin = require('gulp-cssmin')
const rename = require('gulp-rename')
const zip = require('gulp-zip')

// determines the name of the ZIP file
Expand All @@ -24,53 +21,19 @@ gulp.task('archive', [ 'archive:files' ], function() {

gulp.task('archive:files', [
'archive:packages',
'archive:packages:minjs',
'archive:packages:mincss',
'archive:demos',
'archive:vendor',
'archive:meta'
])

gulp.task('archive:packages', [ 'build' ], function() {
gulp.task('archive:packages', [ 'build', 'minify' ], function() {
return gulp.src([
'dist/**/*.{js,css}'
]).pipe(
gulp.dest('tmp/' + archiveId + '/packages')
)
})

gulp.task('archive:packages:minjs', [ 'archive:packages' ], function() {
return gulp.src([
'tmp/' + archiveId + '/packages/*/*.js',
'!**/*.min.js' // avoid double minify
], { base: '.' })
.pipe(
uglify({
preserveComments: 'some' // keep comments starting with !
})
)
.pipe(
rename({ extname: '.min.js' })
)
.pipe(gulp.dest('.'))
})

gulp.task('archive:packages:mincss', [ 'archive:packages' ], function() {
return gulp.src([
'tmp/' + archiveId + '/packages/*/*.css',
'!**/*.min.css' // avoid double minify
], { base: '.' })
.pipe(
cssmin()
)
.pipe(
rename({ extname: '.min.css' })
)
.pipe(
gulp.dest('.')
)
})

gulp.task('archive:meta', function() {
return gulp.src([
'LICENSE.*',
Expand Down
41 changes: 41 additions & 0 deletions tasks/minify.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
const gulp = require('gulp')
const uglify = require('gulp-uglify')
const cssmin = require('gulp-cssmin')
const rename = require('gulp-rename')

gulp.task('minify', [
'minify:js',
'minify:css'
])

gulp.task('minify:js', [ 'build' ], function() {
return gulp.src([
'dist/*/*.js',
'!**/*.min.js' // avoid double minify
], { base: '.' })
.pipe(
uglify({
preserveComments: 'some' // keep comments starting with !
})
)
.pipe(
rename({ extname: '.min.js' })
)
.pipe(gulp.dest('.'))
})

gulp.task('minify:css', [ 'build' ], function() {
return gulp.src([
'dist/*/*.css',
'!**/*.min.css' // avoid double minify
], { base: '.' })
.pipe(
cssmin()
)
.pipe(
rename({ extname: '.min.css' })
)
.pipe(
gulp.dest('.')
)
})
1 change: 1 addition & 0 deletions tasks/package-meta.js
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ function buildPackageConfig(packageName, overrides) {
}

res.main = 'main.js'
res.unpkg = 'main.min.js'
res.types = 'main.d.ts'

return res
Expand Down

0 comments on commit 61a1464

Please sign in to comment.