defaultAllDay

fullcalendar · Apr 13, 2020 · 7c14428 · 7c14428
1 parent 3a4f09c
commit 7c14428
Show file tree

Hide file tree

Showing 10 changed files with 36 additions and 36 deletions.
diff --git a/packages/__tests__/manual/options.html b/packages/__tests__/manual/options.html
@@ -53,7 +53,7 @@
       slotMinutes: 15,
       defaultEventMinutes: 45,
 
-      //allDayDefault: false,
+      //defaultAllDay: false,
 
       /*
       titleFormat: {

diff --git a/packages/__tests__/manual/sources_new.html b/packages/__tests__/manual/sources_new.html
@@ -16,7 +16,7 @@
 endParam
 cacheParam
 ignoreTimezone
-allDayDefault
+defaultAllDay
 editable
 eventColor
 eventTextColor
@@ -28,7 +28,7 @@
 endParam
 cacheParam
 ignoreTimezone
-allDayDefault
+defaultAllDay
 className
 editable
 color

diff --git a/packages/__tests__/src/datelib/rrule.js b/packages/__tests__/src/datelib/rrule.js
@@ -162,9 +162,9 @@ describe('rrule plugin', function() {
     expect(events[0].allDay).toBe(true)
   })
 
-  it('inherits allDayDefault from source', function() {
+  it('inherits defaultAllDay from source', function() {
     initCalendar({
-      allDayDefault: false,
+      defaultAllDay: false,
       events: [
         {
           rrule: {
@@ -181,10 +181,10 @@ describe('rrule plugin', function() {
     expect(events[0].allDay).toBe(false)
   })
 
-  it('inherits allDayDefault from source setting', function() {
+  it('inherits defaultAllDay from source setting', function() {
     initCalendar({
       eventSources: [ {
-        allDayDefault: false,
+        defaultAllDay: false,
         events: [
           {
             rrule: {

diff --git a/packages/__tests__/src/legacy/allDayDefault.js b/packages/__tests__/src/legacy/allDayDefault.js
@@ -1,5 +1,5 @@
 
-describe('allDayDefault', function() {
+describe('defaultAllDay', function() { // TODO: rename file
   describe('when undefined', function() {
 
     it('guesses false if T in ISO8601 start date', function() {
@@ -91,7 +91,7 @@ describe('allDayDefault', function() {
 
     it('has an effect when an event\'s allDay is not specified', function() {
       initCalendar({
-        allDayDefault: false,
+        defaultAllDay: false,
         events: [
           {
             id: '1',
@@ -105,7 +105,7 @@ describe('allDayDefault', function() {
 
     it('has no effect when an event\'s allDay is specified', function() {
       initCalendar({
-        allDayDefault: false,
+        defaultAllDay: false,
         events: [
           {
             id: '1',
@@ -122,13 +122,13 @@ describe('allDayDefault', function() {
 
 })
 
-describe('source.allDayDefault', function() {
+describe('source.defaultAllDay', function() {
 
   it('has an effect when an event\'s allDay is not specified', function() {
     initCalendar({
       eventSources: [
         {
-          allDayDefault: false,
+          defaultAllDay: false,
           events: [
             {
               id: '1',
@@ -142,12 +142,12 @@ describe('source.allDayDefault', function() {
     expect(eventObj.allDay).toEqual(false)
   })
 
-  it('a true value can override the global allDayDefault', function() {
+  it('a true value can override the global defaultAllDay', function() {
     initCalendar({
-      allDayDefault: false,
+      defaultAllDay: false,
       eventSources: [
         {
-          allDayDefault: true,
+          defaultAllDay: true,
           events: [
             {
               id: '1',
@@ -161,12 +161,12 @@ describe('source.allDayDefault', function() {
     expect(eventObj.allDay).toEqual(true)
   })
 
-  it('a false value can override the global allDayDefault', function() {
+  it('a false value can override the global defaultAllDay', function() {
     initCalendar({
-      allDayDefault: true,
+      defaultAllDay: true,
       eventSources: [
         {
-          allDayDefault: false,
+          defaultAllDay: false,
           events: [
             {
               id: '1',
@@ -184,7 +184,7 @@ describe('source.allDayDefault', function() {
     initCalendar({
       eventSources: [
         {
-          allDayDefault: true,
+          defaultAllDay: true,
           events: [
             {
               id: '1',

diff --git a/packages/__tests__/src/legacy/event-obj.js b/packages/__tests__/src/legacy/event-obj.js
@@ -5,7 +5,7 @@ describe('event object creation', function() {
   NOTE: Where possible, if there is a specific option that affects event object creation
   behavior, write your tests in the individual file for that option, instead of here.
   Examples of this:
-    allDayDefault (tests allDay guessing behavior too)
+    defaultAllDay (tests allDay guessing behavior too)
     eventDataTransform
     forceEventDuration
 

diff --git a/packages/core/src/options.ts b/packages/core/src/options.ts
@@ -42,7 +42,7 @@ export const globalDefaults = {
 
   timeZone: 'local', // TODO: throw error if given falsy value?
 
-  // allDayDefault: undefined,
+  // defaultAllDay: undefined,
 
   // locale
   locales: [],

diff --git a/packages/core/src/structs/event-source.ts b/packages/core/src/structs/event-source.ts
@@ -25,7 +25,7 @@ export type EventSourceErrorResponseHandler = (error: EventSourceError) => void
 
 export interface ExtendedEventSourceInput {
   id?: string | number // only accept number?
-  allDayDefault?: boolean
+  defaultAllDay?: boolean
   eventDataTransform?: EventInputTransformer
 
   // array or function (TODO: move this to array-event-source/func-event-source?)
@@ -73,7 +73,7 @@ export interface EventSource {
   isFetching: boolean
   latestFetchId: string
   fetchRange: DateRange | null
-  allDayDefault: boolean | null
+  defaultAllDay: boolean | null
   eventDataTransform: EventInputTransformer
   ui: EventUi
   success: EventSourceSuccessResponseHandler | null
@@ -101,7 +101,7 @@ export interface EventSourceDef {
 
 const SIMPLE_SOURCE_PROPS = {
   id: String,
-  allDayDefault: Boolean,
+  defaultAllDay: Boolean,
   eventDataTransform: Function,
   success: Function,
   failure: Function

diff --git a/packages/core/src/structs/event.ts b/packages/core/src/structs/event.ts
@@ -78,11 +78,11 @@ export const DATE_PROPS = {
 
 
 export function parseEvent(raw: EventInput, sourceId: string, calendar: Calendar, allowOpenRange?: boolean): EventTuple | null {
-  let allDayDefault = computeIsAllDayDefault(sourceId, calendar)
+  let defaultAllDay = computeIsdefaultAllDay(sourceId, calendar)
   let leftovers0 = {}
   let recurringRes = parseRecurring(
     raw, // raw, but with single-event stuff stripped out
-    allDayDefault,
+    defaultAllDay,
     calendar.dateEnv,
     calendar.pluginSystem.hooks.recurringTypes,
     leftovers0 // will populate with non-recurring props
@@ -101,7 +101,7 @@ export function parseEvent(raw: EventInput, sourceId: string, calendar: Calendar
 
   } else {
     let leftovers1 = {}
-    let singleRes = parseSingle(raw, allDayDefault, calendar, leftovers1, allowOpenRange)
+    let singleRes = parseSingle(raw, defaultAllDay, calendar, leftovers1, allowOpenRange)
 
     if (singleRes) {
       let def = parseEventDef(leftovers1, sourceId, singleRes.allDay, singleRes.hasEnd, calendar)
@@ -164,7 +164,7 @@ export function createEventInstance(
 }
 
 
-function parseSingle(raw: EventInput, allDayDefault: boolean | null, calendar: Calendar, leftovers?, allowOpenRange?: boolean) {
+function parseSingle(raw: EventInput, defaultAllDay: boolean | null, calendar: Calendar, leftovers?, allowOpenRange?: boolean) {
   let props = pluckDateProps(raw, leftovers)
   let allDay = props.allDay
   let startMeta
@@ -186,8 +186,8 @@ function parseSingle(raw: EventInput, allDayDefault: boolean | null, calendar: C
   }
 
   if (allDay == null) {
-    if (allDayDefault != null) {
-      allDay = allDayDefault
+    if (defaultAllDay != null) {
+      allDay = defaultAllDay
     } else {
       // fall back to the date props LAST
       allDay = (!startMeta || startMeta.isTimeUnspecified) &&
@@ -258,16 +258,16 @@ function pluckNonDateProps(raw: EventInput, calendar: Calendar, leftovers?) {
 }
 
 
-function computeIsAllDayDefault(sourceId: string, calendar: Calendar): boolean | null {
+function computeIsdefaultAllDay(sourceId: string, calendar: Calendar): boolean | null {
   let res = null
 
   if (sourceId) {
     let source = calendar.state.eventSources[sourceId]
-    res = source.allDayDefault
+    res = source.defaultAllDay
   }
 
   if (res == null) {
-    res = calendar.opt('allDayDefault')
+    res = calendar.opt('defaultAllDay')
   }
 
   return res

diff --git a/packages/core/src/structs/recurring-event.ts b/packages/core/src/structs/recurring-event.ts
@@ -23,7 +23,7 @@ export interface RecurringType {
 
 export function parseRecurring(
   eventInput: EventInput,
-  allDayDefault: boolean | null,
+  defaultAllDay: boolean | null,
   dateEnv: DateEnv,
   recurringTypes: RecurringType[],
   leftovers: any
@@ -37,7 +37,7 @@ export function parseRecurring(
       let allDay = localLeftovers.allDay
       delete localLeftovers.allDay // remove from leftovers
       if (allDay == null) {
-        allDay = allDayDefault
+        allDay = defaultAllDay
         if (allDay == null) {
           allDay = parsed.allDayGuess
           if (allDay == null) {

diff --git a/packages/core/src/types/input-types.ts b/packages/core/src/types/input-types.ts
@@ -155,7 +155,7 @@ export interface OptionsInputBase {
   eventColor?: string
   events?: EventSourceInput
   eventSources?: EventSourceInput[]
-  allDayDefault?: boolean
+  defaultAllDay?: boolean
   startParam?: string
   endParam?: string
   lazyFetching?: boolean