Skip to content

Commit

Permalink
lock node version
Browse files Browse the repository at this point in the history
  • Loading branch information
arshaw committed Oct 26, 2021
1 parent 572a590 commit 9f3f626
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
engine-strict=true
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -97,5 +97,8 @@
"dist": "gulp dist",
"lint": "gulp lint-and-example-repos",
"test": "gulp test:single"
},
"engines": {
"node": "^11.0.0"
}
}

5 comments on commit 9f3f626

@ThiefMaster
Copy link

@ThiefMaster ThiefMaster commented on 9f3f626 Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for this change? I'm using 3.10.2 without any problems on a more recent node version... Locking a long-EOL version isn't great..

@coffe4u
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on node 12.x and everything was fine until this.

@jakenewby
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had to add a yarn resolution to prevent an installation error due to this change to require node v11.

@coffe4u
Copy link

@coffe4u coffe4u commented on 9f3f626 Nov 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakenewby I got around it by using yarn install --ignore-engines but I'm not really a fan of having to do that.

@jakenewby
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coffe4u agreed, not optimal. I opted to rollback to the older version instead. I'd like to not block other packages from requiring certain versions of node if it is necessary to do so.

Please sign in to comment.