Skip to content

Commit

Permalink
fixes for tests;
Browse files Browse the repository at this point in the history
  • Loading branch information
arshaw committed Jun 5, 2020
1 parent 6000162 commit cbcc5b7
Show file tree
Hide file tree
Showing 6 changed files with 24 additions and 24 deletions.
16 changes: 7 additions & 9 deletions packages/__tests__/src/event-drag/repeating.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { TimeGridViewWrapper } from '../lib/wrappers/TimeGridViewWrapper'
import { CalendarWrapper } from '../lib/wrappers/CalendarWrapper'
import { waitEventDrag } from '../lib/wrappers/interaction-util'
import { filterVisibleEls } from '../lib/dom-misc'
import { DayGridViewWrapper } from '../lib/wrappers/DayGridViewWrapper'

describe('event dragging on repeating events', function() {
pushOptions({
Expand Down Expand Up @@ -42,25 +43,22 @@ describe('event dragging on repeating events', function() {
})

it('hides other repeating events when dragging', function(done) {

let calendar = initCalendar({

eventDragStart() {
setTimeout(function() { // try go execute DURING the drag
let visibleEventEls = filterVisibleEls(calendarWrapper.getEventEls())
let visibleEventEls = filterVisibleEls(dayGridWrapper.getEventEls())
expect(visibleEventEls.length).toBe(0)
}, 0)
},

eventDrop() {
setTimeout(function() {
done()
}, 10)
}
})
let calendarWrapper = new CalendarWrapper(calendar)
let dayGridWrapper = new DayGridViewWrapper(calendar).dayGrid

$(calendarWrapper.getFirstEventEl()).simulate('drag', {
$(dayGridWrapper.getFirstEventEl()).simulate('drag', {
dx: 100,
duration: 100 // ample time for separate eventDragStart/eventDrop
})
Expand All @@ -83,7 +81,7 @@ describe('event dragging on repeating events', function() {

eventDragStart() {
setTimeout(function() { // try go execute DURING the drag
let visibleEventEls = filterVisibleEls(calendarWrapper.getEventEls())
let visibleEventEls = filterVisibleEls(dayGridWrapper.getEventEls())
expect(visibleEventEls.length).toBe(1) // the dragging event AND the other regular event
}, 0)
},
Expand All @@ -94,9 +92,9 @@ describe('event dragging on repeating events', function() {
}, 10)
}
})
let calendarWrapper = new CalendarWrapper(calendar)
let dayGridWrapper = new DayGridViewWrapper(calendar).dayGrid

$(calendarWrapper.getFirstEventEl()).simulate('drag', {
$(dayGridWrapper.getFirstEventEl()).simulate('drag', {
dx: 100,
duration: 100 // ample time for separate eventDragStart/eventDrop
})
Expand Down
3 changes: 3 additions & 0 deletions packages/__tests__/src/event-render/dayGrid-events.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ import { anyElsIntersect } from '../lib/dom-geom'


describe('dayGrid advanced event rendering', function() {
pushOptions({
initialDate: '2020-05-01'
})

// https://github.com/fullcalendar/fullcalendar/issues/5408
it('renders without intersecting', function() {
Expand Down
13 changes: 6 additions & 7 deletions packages/__tests__/src/lib/EventResizeUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,13 @@ import { CalendarWrapper } from './wrappers/CalendarWrapper'


export function resize(point0, point1, fromStart, debug) {
var $eventEl = $(new CalendarWrapper(currentCalendar).getFirstEventEl())
var eventEl = new CalendarWrapper(currentCalendar).getFirstEventEl()

$eventEl.simulate('mouseover') // so that resize handle is revealed

var resizerEl = $eventEl.find(
var $resizerEl = $(eventEl).find(
'.' + (fromStart ? CalendarWrapper.EVENT_START_RESIZER_CLASSNAME : CalendarWrapper.EVENT_END_RESIZER_CLASSNAME)
)
var resizerRect = resizerEl[0].getBoundingClientRect()
).css('display', 'block') // usually only displays on hover. force display

var resizerRect = $resizerEl[0].getBoundingClientRect()
var resizerCenter = getRectCenter(resizerRect)

var vector = subtractPoints(
Expand All @@ -23,7 +22,7 @@ export function resize(point0, point1, fromStart, debug) {
)
var deferred = $.Deferred()

resizerEl.simulate('drag', {
$resizerEl.simulate('drag', {
point: resizerCenter,
end: endPoint,
debug: debug
Expand Down
3 changes: 2 additions & 1 deletion packages/__tests__/src/lib/dnd-resize-utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,9 @@ export function testEventResize(options, resizeDate, expectSuccess, callback, ev
let eventEls = calendarWrapper.getEventEls()
return $(eventEls[eventEls.length - 1]) // the last one
})()

$dragEl = $eventEl.find('.' + CalendarWrapper.EVENT_RESIZER_CLASSNAME)
.css('display', 'block') // resizer usually only shows on hover. force-show it

if (resizeDateHasTime) {
var timeGridWrapper = new TimeGridViewWrapper(calendar).timeGrid
Expand All @@ -142,7 +144,6 @@ export function testEventResize(options, resizeDate, expectSuccess, callback, ev
expect($dragEl.length).toBe(1)
dx = $lastDayEl.offset().left + $lastDayEl.outerWidth() - 2 - ($eventEl.offset().left + $eventEl.outerWidth())

$dragEl.simulate('mouseover') // resizer only shows up on mouseover
$dragEl.simulate('drag', {
dx: dx,
dy: dy,
Expand Down
7 changes: 3 additions & 4 deletions packages/__tests__/src/lib/wrappers/DayGridWrapper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -262,11 +262,10 @@ export class DayGridWrapper {
let rect0 = this.getDayEl(origEndDate).getBoundingClientRect()
let rect1 = this.getDayEl(newEndDate).getBoundingClientRect()

$(eventEl).simulate('mouseover') // so that resize handle is revealed

var resizerEl = eventEl.querySelector(
let resizerEl = $(eventEl).find(
'.' + (fromStart ? CalendarWrapper.EVENT_START_RESIZER_CLASSNAME : CalendarWrapper.EVENT_END_RESIZER_CLASSNAME)
)
).css('display', 'block')[0] // usually only displays on hover. force display

var resizerRect = resizerEl.getBoundingClientRect()
var resizerCenter = getRectCenter(resizerRect)

Expand Down
6 changes: 3 additions & 3 deletions packages/__tests__/src/lib/wrappers/TimeGridWrapper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export class TimeGridWrapper {


getColEl(col) {
return this.el.querySelectorAll('.fc-timegrid-col')[col] as HTMLElement
return this.el.querySelectorAll('.fc-timegrid-col:not(.fc-timegrid-axis)')[col] as HTMLElement
}


Expand Down Expand Up @@ -159,9 +159,9 @@ export class TimeGridWrapper {

resizeEvent(eventEl: HTMLElement, origEndDate, newEndDate, onBeforeRelease?) {
return new Promise((resolve) => {
$(eventEl).simulate('mouseover') // resizer only shows on hover
let resizerEl = $(eventEl).find('.' + CalendarWrapper.EVENT_RESIZER_CLASSNAME)
.css('display', 'block')[0] // usually only displays on hover. force display

let resizerEl = eventEl.querySelector('.' + CalendarWrapper.EVENT_RESIZER_CLASSNAME)
let resizerPoint = getRectCenter(resizerEl.getBoundingClientRect())
let origPoint = this.getPoint(origEndDate)
let yCorrect = resizerPoint.top - origPoint.top
Expand Down

0 comments on commit cbcc5b7

Please sign in to comment.