lintBuilt, with dts linting

gulpfile.js

@@ -337,6 +337,7 @@ const exec3 = require('./scripts/lib/shell').sync.withOptions({
   exitOnError: false
 })
 
+
 exports.eslint = function() {
   let anyFailures = false
 
@@ -366,27 +367,26 @@ exports.eslint = function() {
   return Promise.resolve()
 }
 
-exports.stylelint = function() { // on BUILT css
+
+exports.lintBuiltCss = function() {
   let anyFailures = false
 
-  for (let struct of allStructs) {
-    if (struct.name !== '@fullcalendar/core-vdom') {
-      let builtCssFile = path.join(struct.dir, 'main.css')
-
-      if (fs.existsSync(builtCssFile)) {
-        let cmd = [
-          'stylelint', '--config', 'stylelint.config.js',
-          builtCssFile
-        ]
-
-        console.log('Running stylelint on', struct.name, '...')
-        console.log(cmd.join(' '))
-        console.log()
-
-        let { success } = exec3(cmd)
-        if (!success) {
-          anyFailures = true
-        }
+  for (let struct of publicPackageStructs) {
+    let builtCssFile = path.join(struct.dir, 'main.css')
+
+    if (fs.existsSync(builtCssFile)) {
+      let cmd = [
+        'stylelint', '--config', 'stylelint.config.js',
+        builtCssFile
+      ]
+
+      console.log('Running stylelint on', struct.name, '...')
+      console.log(cmd.join(' '))
+      console.log()
+
+      let { success } = exec3(cmd)
+      if (!success) {
+        anyFailures = true
       }
     }
   }
@@ -399,6 +399,37 @@ exports.stylelint = function() { // on BUILT css
 }
 
 
+exports.lintBuiltDts = function() {
+  let anyFailures = false
+
+  for (let struct of publicPackageStructs) {
+    let dtsFile = path.join(struct.dir, 'main.d.ts')
+    console.log(`Checking ${dtsFile}`)
+
+    // look for bad module declarations (when relative, assumed NOT to be ambient, so BAD)
+    // look for references to react/preact (should always use vdom instead)
+    let { stdout } = require('./scripts/lib/shell').sync([
+      'grep', '-iEe', '(declare module [\'"]\\.|p?react)', dtsFile
+    ])
+
+    stdout = stdout.trim()
+
+    if (stdout) { // don't worry about failure. grep gives failure if no results
+      console.log('  BAD: ' + stdout)
+      anyFailures = true
+    }
+
+    console.log()
+  }
+
+  if (anyFailures) {
+    return Promise.reject(new Error('At least one dts linting job failed'))
+  }
+
+  return Promise.resolve()
+}
+
+
 const REQUIRED_TSLIB_SEMVER = '2'
 
 exports.lintPackageMeta = function() {
@@ -439,3 +470,4 @@ exports.lintPackageMeta = function() {
 
 
 exports.lint = series(exports.lintPackageMeta, exports.eslint)
+exports.lintBuilt = series(exports.lintBuiltCss, exports.lintBuiltDts)

package.json

@@ -42,6 +42,7 @@
     "watch": "gulp watch",
     "clean": "./scripts/clean.sh",
     "lint": "gulp lint",
+    "lintBuilt": "gulp lintBuilt",
     "test": "gulp test",
     "test:ci": "gulp testCi",
     "archive": "gulp archive",

scripts/ci.sh

@@ -8,9 +8,10 @@ FULLCALENDAR_FORCE_REACT=1 yarn run build
 FULLCALENDAR_FORCE_REACT=1 yarn run test:ci
 
 yarn run clean
+yarn run lint
 yarn run build
+yarn run lintBuilt
 yarn run archive
-yarn run lint
 yarn run test:ci
 
 ./scripts/packages-contrib-ci.js