stop using renderVirtual. causes React rendering problems with nested…

… rendering
fullcalendar · Jul 29, 2020 · f79728b · f79728b
1 parent 9becfdb
commit f79728b
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 28 deletions.
diff --git a/packages-premium b/packages-premium
diff --git a/packages/common/src/main.ts b/packages/common/src/main.ts
@@ -69,8 +69,7 @@ export {
   applyStyle,
   applyStyleProp,
   elementMatches,
-  elementClosest,
-  renderVirtual
+  elementClosest
 } from './util/dom-manip'
 export { parseClassNames } from './util/html'
 

diff --git a/packages/common/src/util/dom-manip.ts b/packages/common/src/util/dom-manip.ts
@@ -1,5 +1,4 @@
 import { Dictionary } from '../options'
-import { VNode, render } from '../vdom'
 
 
 export function removeElement(el: HTMLElement) { // removes nodes in addition to elements. bad name
@@ -8,15 +7,6 @@ export function removeElement(el: HTMLElement) { // removes nodes in addition to
   }
 }
 
-export function renderVirtual(v: VNode): HTMLElement { // TODO: use elsewhere?
-  let parentEl = document.createElement('div')
-  render(
-    v as any, // React only specifically accepts a vdom *element*, which we don't have a type for
-    parentEl
-  )
-  return parentEl.firstChild as HTMLElement
-}
-
 
 // Querying
 // ----------------------------------------------------------------------------------------------------------------

diff --git a/packages/common/src/util/table-styling.tsx b/packages/common/src/util/table-styling.tsx
@@ -1,6 +1,3 @@
-import { createElement } from '../vdom'
-import { renderVirtual } from './dom-manip'
-
 
 let canVGrowWithinCell: boolean
 
@@ -14,18 +11,13 @@ export function getCanVGrowWithinCell() {
 
 
 function computeCanVGrowWithinCell() {
-  // TODO: abstraction for creating these temporary detection-based els
-  let el = renderVirtual(
-    <div style={{ position: 'absolute', top: 0, left: 0 }}>
-      <table style={{ height: 100 }}>
-        <tr>
-          <td>
-            <div style={{ height: '100%' }}></div>
-          </td>
-        </tr>
-      </table>
-    </div>
-  )
+  let el = document.createElement('div')
+  el.style.position = 'absolute'
+  el.style.top = '0px'
+  el.style.left = '0px'
+  el.innerHTML = '<div><table><tr><td><div></div></td></tr></table></div>'
+  el.querySelector('table').style.height = '100px'
+  el.querySelector('div').style.height = '100%'
 
   document.body.appendChild(el)