Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eventSourceDataTransform to preprocess event data (such as JSON) #2431

Closed
arshaw opened this issue Aug 19, 2015 · 11 comments
Closed

eventSourceDataTransform to preprocess event data (such as JSON) #2431

arshaw opened this issue Aug 19, 2015 · 11 comments
Labels
Milestone

Comments

@arshaw
Copy link
Member

arshaw commented Aug 19, 2015

Originally reported on Google Code with ID 2166

Similare to eventDataTransform:
http://arshaw.com/fullcalendar/docs/event_data/eventDataTransform/

...but given the root object (be it an array of events, or some higher-level object),
and will return an array of events for fullcalendar to use.

Will be a robust solution for solving problems such as Issue 1733

Reported by adamrshaw on 2014-06-05 21:38:30

Imported with 4 stars.

@arshaw arshaw self-assigned this Aug 19, 2015
@arshaw
Copy link
Member Author

arshaw commented Aug 19, 2015

Issue 2000 has been merged into this issue.

Reported by adamrshaw on 2014-06-05 21:39:41

@arshaw
Copy link
Member Author

arshaw commented Aug 19, 2015

one implementation (called something different): https://github.com/arshaw/fullcalendar/pull/173

Reported by adamrshaw on 2014-06-20 05:34:45

@arshaw
Copy link
Member Author

arshaw commented Aug 19, 2015

Issue 2539 has been merged into this issue.

Reported by adamrshaw on 2014-09-05 19:38:08

@arshaw
Copy link
Member Author

arshaw commented Aug 19, 2015

The eventDataTransform does not give me the chance to discard any incoming json objects.

The flow goes like this :
1.you call the server for events, who will have an unknown json structure
2.eventDataTransform kicks in to map the json to fullCalendar eventObjects
3.what if i encounter some events that I want to consider illegal? and discard them?

The eventDataTransform does not do this, it returns a default eventObject if the return
of the transformer is null or false. Ideally the eventDataTransform would not map an
eventObject if the transformer returns false.

Reported by LorenGRX on 2014-12-03 13:21:57

@arshaw
Copy link
Member Author

arshaw commented Aug 19, 2015

@LorenGRX, can you open up a new issue regarding your proposed enhanced behavior about
eventDataTransform? We'll keep this issue focused on eventSourceDataTransform.

Reported by adamrshaw on 2014-12-15 05:27:45

@eljefedelrodeodeljefe
Copy link

This seems to be stale. Do you require help with it? I see this as very useful, since it's a doubful API style to return JSON arrays.

@arshaw arshaw removed their assignment Nov 30, 2017
@kristiansp
Copy link

I would love to see this added

@arshaw arshaw added this to the v4 milestone Aug 11, 2018
@arshaw
Copy link
Member Author

arshaw commented Aug 11, 2018

i'll get this done for v4. in the meantime, it's rather easy to hack the source code of v3 to get this to work

@arshaw
Copy link
Member Author

arshaw commented Oct 2, 2018

This issue has been addressed in the latest alpha release (4.0.0-alpha.2)
See the blog post »

https://fullcalendar.io/docs/v4/eventSourceSuccess

@arshaw
Copy link
Member Author

arshaw commented Dec 26, 2018

I'm closing this issue to signify that it's implemented (since v4-alpha2). I'll comment on this thread again when v4 is officially released.

@arshaw arshaw closed this as completed Dec 26, 2018
@arshaw
Copy link
Member Author

arshaw commented Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants