Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoiding conflicts with non-standard fields in the Event model #3228

Closed
kujiy opened this issue Jun 17, 2016 · 6 comments
Closed

Avoiding conflicts with non-standard fields in the Event model #3228

kujiy opened this issue Jun 17, 2016 · 6 comments
Labels
Accepted Event Model How event data is parsed and represented in models
Milestone

Comments

@kujiy
Copy link

kujiy commented Jun 17, 2016

I see your doc recommends to use Non-standard Fields but it causes conflict error if fullcalendar has the same name option with the user's custom parameter in feature versions.

I think it's better to recommend to use with a reserved param like userField.

What do you think?

@arshaw
Copy link
Member

arshaw commented Jun 17, 2016

i agree. this change is a little far-off, but i'll revisit this issue when rearchitecting the event model. thanks

@arshaw arshaw changed the title Non-standard Fields causes conflict Avoiding conflicts with non-standard fields in the Event model Jun 17, 2016
@arshaw arshaw added Accepted Event Model How event data is parsed and represented in models labels Jun 17, 2016
@kujiy
Copy link
Author

kujiy commented Jun 21, 2016

Thanks @arshaw . My team members were a bit annoied about this conflict error last week. The first developer knew Non-standard Fields and used lots of custom params. The other people added their original params like him but someone didn't read that manual and conflicted them with existing params like source and url in the manual. Those are common names you know. We fixed the problem by cooping them up inside userField. Anyway, I really appriciate your great project. Thank you again.

@arshaw
Copy link
Member

arshaw commented Jun 21, 2016

understood. thanks @kujiy

@arshaw arshaw added this to the v4 milestone Oct 2, 2018
@arshaw
Copy link
Member

arshaw commented Oct 2, 2018

This issue has been addressed in the latest alpha release (4.0.0-alpha.2)
See the blog post »

https://fullcalendar.io/docs/v4/event-parsing

You can now specify an explicit extendedProps hash

@arshaw
Copy link
Member

arshaw commented Dec 26, 2018

I'm closing this issue to signify that it's implemented (since v4-alpha2). I'll comment on this thread again when v4 is officially released.

@arshaw arshaw closed this as completed Dec 26, 2018
@arshaw
Copy link
Member

arshaw commented Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Event Model How event data is parsed and represented in models
Projects
None yet
Development

No branches or pull requests

2 participants