Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include scss files in release package #4426

Closed
piernik opened this issue Dec 27, 2018 · 9 comments
Closed

Include scss files in release package #4426

piernik opened this issue Dec 27, 2018 · 9 comments

Comments

@piernik
Copy link

piernik commented Dec 27, 2018

All in topic - can You add scss files to dist folder?

@acerix
Copy link
Member

acerix commented Dec 27, 2018

I'm not sure what you are asking, is this a request for a new feature? If this is a question, please refer to the support page and use Stack Overflow for help.

@piernik
Copy link
Author

piernik commented Dec 28, 2018

Feature - add scss files to distribution. Not I can see only css files.

@acerix
Copy link
Member

acerix commented Dec 28, 2018

The scss files are in src since they are source files:

https://github.com/fullcalendar/fullcalendar/blob/v4/src/main.scss

Why are you looking to have those copied to dist?

@piernik
Copy link
Author

piernik commented Dec 29, 2018

I've installed fullcalendar using npm i fullcalendar.
In npm package there are no scss files and should be

@acerix
Copy link
Member

acerix commented Dec 31, 2018

I'm not sure why you'd want source files included in the package, if you need to build from source you should download the source instead.

@acerix acerix changed the title [v4] Adding scss files to dist (or src) Adding scss files to dist (or src) Dec 31, 2018
@acerix acerix changed the title Adding scss files to dist (or src) Include scss files in release package Dec 31, 2018
@piernik
Copy link
Author

piernik commented Jan 2, 2019

I'm using it with angular. With ease I could adopt Your styles for my project since I'm using scss.
I don't have to overwrite css style.

@acerix
Copy link
Member

acerix commented Jan 2, 2019

Since you are compiling it yourself I think you want to clone the source code instead of just getting the package from npm.

@piernik
Copy link
Author

piernik commented Jan 3, 2019

I'm not compiling javascript - only scss :) Do as You want - it was a request.

@acerix
Copy link
Member

acerix commented Feb 6, 2019

There's another issue discussing how to include CSS:
#4490

Please visit the link, give a 👍 to vote (?), press the 🔈Subscribe button to receive updates.

@acerix acerix closed this as completed Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants