Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css variables in v-event.css #5552

Closed
nick-milner opened this issue Jun 27, 2020 · 6 comments
Closed

css variables in v-event.css #5552

nick-milner opened this issue Jun 27, 2020 · 6 comments
Milestone

Comments

@nick-milner
Copy link

Attempting to override time view vertical event background-color css variables from
https://github.com/fullcalendar/fullcalendar/blob/master/packages/timegrid/src/styles/v-event.css

Am i mistaken but aren't these two variables the wrong way around ?

border: 1px solid var(--fc-event-bg-color);
background-color: var(--fc-event-border-color);

ie background-color is using --fc-event-border-color variable, and border is using --fc-event-bg-color

@arshaw arshaw added this to the next-minor milestone Jun 27, 2020
@arshaw
Copy link
Member

arshaw commented Jun 27, 2020

you're right. it won't have any negative effects in the default configuration because both colors are the same by default, but might be bad when customized. i'll fix

@nick-milner
Copy link
Author

Great, thanks! Top work on v5 btw 😀

@arshaw arshaw closed this as completed in 68d60d8 Jun 29, 2020
@arshaw
Copy link
Member

arshaw commented Jun 29, 2020

fixed in v5.1.0

@nick-milner
Copy link
Author

@arshaw
Copy link
Member

arshaw commented Jul 1, 2020

yes, thanks @nick-milner

@arshaw arshaw reopened this Jul 1, 2020
@arshaw arshaw modified the milestones: v5.1.0, next-minor Jul 1, 2020
@arshaw arshaw closed this as completed in a5a6e9b Jul 29, 2020
@arshaw
Copy link
Member

arshaw commented Aug 1, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants