Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

height/contentHeight accept function for dynamic value #3040

Merged
merged 1 commit into from Jul 31, 2016
Merged

height/contentHeight accept function for dynamic value #3040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Calendar.js
View file
Open in desktop
Expand Up @@ -667,6 +667,10 @@ function Calendar_constructor(element, overrides) {


function _calcSize() { // assumes elementVisible
if (typeof options.getContainerHeight === 'function') {
suggestedViewHeight = options.getContainerHeight() - (headerElement ? headerElement.outerHeight(true) : 0);
return;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you leverage the else if chain instead of doing a return?

}
if (typeof options.contentHeight === 'number') { // exists and not 'auto'
suggestedViewHeight = options.contentHeight;
}
Expand Down